Jump to page: 1 2 3
Thread overview
[dmd-internals] [D-Programming-Language/dmd] 10640a: dang, forgot that one, too
Nov 06, 2012
GitHub
Nov 06, 2012
Jacob Carlborg
Nov 06, 2012
Walter Bright
Nov 06, 2012
Jacob Carlborg
Nov 06, 2012
Walter Bright
Nov 07, 2012
Jacob Carlborg
Nov 07, 2012
David Nadlinger
Nov 07, 2012
Don Clugston
Nov 06, 2012
Leandro Lucarella
Nov 07, 2012
Walter Bright
Nov 07, 2012
Brad Roberts
Nov 07, 2012
Walter Bright
Nov 07, 2012
Leandro Lucarella
Nov 07, 2012
Jonathan M Davis
Nov 07, 2012
Leandro Lucarella
Nov 07, 2012
Jason House
Nov 07, 2012
Jacob Carlborg
Nov 07, 2012
David Nadlinger
Nov 07, 2012
Jason House
Nov 07, 2012
Jacob Carlborg
Nov 07, 2012
Jonathan M Davis
Nov 07, 2012
David Nadlinger
Nov 07, 2012
Jacob Carlborg
November 06, 2012
  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd
  Commit: 10640a73130a7d6802d1e72da9e3b45af065f512
      https://github.com/D-Programming-Language/dmd/commit/10640a73130a7d6802d1e72da9e3b45af065f512
  Author: Walter Bright <walter@walterbright.com>
  Date:   2012-11-06 (Tue, 06 Nov 2012)

  Changed paths:
    M src/backend/cv8.c

  Log Message:
  -----------
  dang, forgot that one, too





November 06, 2012
On 6 nov 2012, at 16:44, GitHub <noreply@github.com> wrote:

>  Branch: refs/heads/master
>  Home:   https://github.com/D-Programming-Language/dmd
>  Commit: 10640a73130a7d6802d1e72da9e3b45af065f512
>      https://github.com/D-Programming-Language/dmd/commit/10640a73130a7d6802d1e72da9e3b45af065f512
>  Author: Walter Bright <walter@walterbright.com>
>  Date:   2012-11-06 (Tue, 06 Nov 2012)
> 
>  Changed paths:
>    M src/backend/cv8.c
> 
>  Log Message:
>  -----------
>  dang, forgot that one, too

I don't know how your workflow with git is. But I usually just make the changes I want and then commit them with this command:

$ git commit -a -m "Message"

The "-a" flag will include all changes in all files tracked by git. It won't add any new files.

-- 
/Jacob Carlborg

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

November 06, 2012
> I don't know how your workflow with git is. But I usually just make the changes I want and then commit them with this command: $ git commit -a -m "Message" The "-a" flag will include all changes in all files tracked by git. It won't add any new files.

I develop on Windows, but my git install is on linux. I copy the changed files over to linux, then run the git commands. Yeah, I know it's not the usual git workflow, but git sux on Windows, and I don't care for the grief.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

November 06, 2012
On 6 nov 2012, at 21:24, Walter Bright <walter@digitalmars.com> wrote:

> I develop on Windows, but my git install is on linux. I copy the changed files over to linux, then run the git commands. Yeah, I know it's not the usual git workflow, but git sux on Windows, and I don't care for the grief.


Not arguing there. But can't you use a shared folder between Windows and Linux? Setup Samba in Linux or use SSH mount to mount a Linux folder in Windows. Then use Putty to SSH into the Linux computer from Windows. You will do all your work on the Windows machine but the files will be saved on the Linux machine.

-- 
/Jacob Carlborg

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

November 06, 2012
On 11/6/2012 12:41 PM, Jacob Carlborg wrote:
> On 6 nov 2012, at 21:24, Walter Bright <walter@digitalmars.com> wrote:
>
>> I develop on Windows, but my git install is on linux. I copy the changed files over to linux, then run the git commands. Yeah, I know it's not the usual git workflow, but git sux on Windows, and I don't care for the grief.
>
> Not arguing there. But can't you use a shared folder between Windows and Linux? Setup Samba in Linux or use SSH mount to mount a Linux folder in Windows. Then use Putty to SSH into the Linux computer from Windows. You will do all your work on the Windows machine but the files will be saved on the Linux machine.
>

I've never been able to get that to work. I just use pscp to copy the files.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

November 07, 2012
Jacob Carlborg, el  6 de November a las 20:56 me escribiste:
> 
> On 6 nov 2012, at 16:44, GitHub <noreply@github.com> wrote:
> 
> >  Branch: refs/heads/master
> >  Home:   https://github.com/D-Programming-Language/dmd
> >  Commit: 10640a73130a7d6802d1e72da9e3b45af065f512
> >      https://github.com/D-Programming-Language/dmd/commit/10640a73130a7d6802d1e72da9e3b45af065f512
> >  Author: Walter Bright <walter@walterbright.com>
> >  Date:   2012-11-06 (Tue, 06 Nov 2012)
> > 
> >  Changed paths:
> >    M src/backend/cv8.c
> > 
> >  Log Message:
> >  -----------
> >  dang, forgot that one, too
> 
> I don't know how your workflow with git is. But I usually just make the changes I want and then commit them with this command:
> 
> $ git commit -a -m "Message"
> 
> The "-a" flag will include all changes in all files tracked by git. It won't add any new files.

Also, it could be a good idea to avoid compulsive commits and using the autotester. If a commit is broken, you can always fix it by making the appropriate changes and doing a git commit --amend -a to fix the commit and void these useless commits of "I forgot yada". This will also not break git bisect.

You can even fix an older commit by using git rebase -i. Of course you should only amend commits that are not in the official repo.

Also, following the pull request path as everybody else could prevent a lot of these kind of errors while committing. Maybe you should consider doing that, at least to ensure all your commits pass the tests.

-- 
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

November 06, 2012
On 11/6/2012 3:59 PM, Leandro Lucarella wrote:
> Jacob Carlborg, el  6 de November a las 20:56 me escribiste:
>> On 6 nov 2012, at 16:44, GitHub <noreply@github.com> wrote:
>>
>>>   Branch: refs/heads/master
>>>   Home:   https://github.com/D-Programming-Language/dmd
>>>   Commit: 10640a73130a7d6802d1e72da9e3b45af065f512
>>>       https://github.com/D-Programming-Language/dmd/commit/10640a73130a7d6802d1e72da9e3b45af065f512
>>>   Author: Walter Bright <walter@walterbright.com>
>>>   Date:   2012-11-06 (Tue, 06 Nov 2012)
>>>
>>>   Changed paths:
>>>     M src/backend/cv8.c
>>>
>>>   Log Message:
>>>   -----------
>>>   dang, forgot that one, too
>> I don't know how your workflow with git is. But I usually just make the changes I want and then commit them with this command:
>>
>> $ git commit -a -m "Message"
>>
>> The "-a" flag will include all changes in all files tracked by git. It won't add any new files.
> Also, it could be a good idea to avoid compulsive commits and using the
> autotester. If a commit is broken, you can always fix it by making the
> appropriate changes and doing a git commit --amend -a to fix the commit and
> void these useless commits of "I forgot yada". This will also not break git
> bisect.
>
> You can even fix an older commit by using git rebase -i. Of course you should
> only amend commits that are not in the official repo.
>
> Also, following the pull request path as everybody else could prevent a lot of
> these kind of errors while committing. Maybe you should consider doing that, at
> least to ensure all your commits pass the tests.

I do run the test suite locally before committing.

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

November 06, 2012
On 11/6/2012 7:44 PM, Walter Bright wrote:

> 
> I do run the test suite locally before committing.
> 

On all platforms?  On the code you _actually_ committed not vs what you have in some other client?

Based on the frequency of omitting a file and/or seeing a broken build, the answer to both of those is all too often
'no'.  Both of which would be true if you followed the pull + merge model that everyone else follows.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

November 06, 2012
On 11/6/2012 9:04 PM, Brad Roberts wrote:
> On 11/6/2012 7:44 PM, Walter Bright wrote:
>
>> I do run the test suite locally before committing.
>>
> On all platforms?  On the code you _actually_ committed not vs what you have in some other client?
>
> Based on the frequency of omitting a file and/or seeing a broken build, the answer to both of those is all too often
> 'no'.  Both of which would be true if you followed the pull + merge model that everyone else follows.

I run it on all the platforms but FreeBSD64 and then copy the files to the git repository on Linux.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

November 07, 2012
Walter Bright, el  6 de November a las 22:12 me escribiste:
> 
> On 11/6/2012 9:04 PM, Brad Roberts wrote:
> >On 11/6/2012 7:44 PM, Walter Bright wrote:
> >
> >>I do run the test suite locally before committing.
> >>
> >On all platforms?  On the code you _actually_ committed not vs what you have in some other client?
> >
> >Based on the frequency of omitting a file and/or seeing a broken build, the answer to both of those is all too often 'no'.  Both of which would be true if you followed the pull + merge model that everyone else follows.
> 
> I run it on all the platforms but FreeBSD64 and then copy the files to the git repository on Linux.

That clearly doesn't detect errors when you forgot to commit stuff. Is NOT the same as going through the autotester which compiles everything from a fresh checkout.

-- 
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

« First   ‹ Prev
1 2 3