Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd
  Commit: e8180241efadb87dc2877878450dac1dc533413b
      https://github.com/D-Programming-Language/dmd/commit/e8180241efadb87dc2877878450dac1dc533413b
  Author: Walter Bright <walter@walterbright.com>
  Date:   2013-01-06 (Sun, 06 Jan 2013)

  Changed paths:
    M src/backend/code.h

  Log Message:
  -----------
  forgot code.h

Walter, is there any point where you're going to hold yourself to the same process everyone else does and start using pull requests and the auto-tester to validate your work?

On 1/6/2013 3:09 PM, GitHub wrote:
>   Branch: refs/heads/master
>   Home:   https://github.com/D-Programming-Language/dmd
>   Commit: e8180241efadb87dc2877878450dac1dc533413b
>       https://github.com/D-Programming-Language/dmd/commit/e8180241efadb87dc2877878450dac1dc533413b
>   Author: Walter Bright <walter@walterbright.com>
>   Date:   2013-01-06 (Sun, 06 Jan 2013)
> 
>   Changed paths:
>     M src/backend/code.h
> 
>   Log Message:
>   -----------
>   forgot code.h
> 

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

In this particular case, I did test it. I just forgot to push one of the files.

On 1/6/2013 3:20 PM, Brad Roberts wrote:
> Walter, is there any point where you're going to hold yourself to the same process everyone else does and start using
> pull requests and the auto-tester to validate your work?
>
> On 1/6/2013 3:09 PM, GitHub wrote:
>>    Branch: refs/heads/master
>>    Home:   https://github.com/D-Programming-Language/dmd
>>    Commit: e8180241efadb87dc2877878450dac1dc533413b
>>        https://github.com/D-Programming-Language/dmd/commit/e8180241efadb87dc2877878450dac1dc533413b
>>    Author: Walter Bright <walter@walterbright.com>
>>    Date:   2013-01-06 (Sun, 06 Jan 2013)
>>
>>    Changed paths:
>>      M src/backend/code.h
>>
>>    Log Message:
>>    -----------
>>    forgot code.h
>>
> _______________________________________________
> dmd-internals mailing list
> dmd-internals@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>
>

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 1/6/2013 3:20 PM, Brad Roberts wrote:
> Walter, is there any point where you're going to hold yourself to the same process everyone else does and start using
> pull requests and the auto-tester to validate your work?
>

I'm fine doing that for druntime and phobos, but am still a little reluctant for doing it with dmd.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

Which the pull testing would have caught before impacting anything.  Please start using the process everyone else does.
 There's no good reason not to.

On 1/6/2013 4:40 PM, Walter Bright wrote:
> In this particular case, I did test it. I just forgot to push one of the files.
> 
> On 1/6/2013 3:20 PM, Brad Roberts wrote:
>> Walter, is there any point where you're going to hold yourself to the same process everyone else does and start using pull requests and the auto-tester to validate your work?
>>
>> On 1/6/2013 3:09 PM, GitHub wrote:
>>>    Branch: refs/heads/master
>>>    Home:   https://github.com/D-Programming-Language/dmd
>>>    Commit: e8180241efadb87dc2877878450dac1dc533413b
>>>        https://github.com/D-Programming-Language/dmd/commit/e8180241efadb87dc2877878450dac1dc533413b
>>>    Author: Walter Bright <walter@walterbright.com>
>>>    Date:   2013-01-06 (Sun, 06 Jan 2013)
>>>
>>>    Changed paths:
>>>      M src/backend/code.h
>>>
>>>    Log Message:
>>>    -----------
>>>    forgot code.h
>>>

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On Sunday, January 06, 2013 16:48:54 Walter Bright wrote:
> On 1/6/2013 3:20 PM, Brad Roberts wrote:
> > Walter, is there any point where you're going to hold yourself to the same process everyone else does and start using pull requests and the auto-tester to validate your work?
> 
> I'm fine doing that for druntime and phobos, but am still a little reluctant for doing it with dmd.

Even if you were merging all of your pull requests for dmd yourself rather than waiting for reviews like everyone else does, by using pull requests, you'd at least avoid breaking the build due to forgetting to commit everything, and you'd get your changes tested on all of our platforms by the pull tester. I don't see any reason for you not to do at least do that much, and I thought that that's what you had previously agreed to start doing.

- Jonathan M Davis
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 1/6/2013 5:08 PM, Jonathan M Davis wrote:
> Even if you were merging all of your pull requests for dmd yourself rather than waiting for reviews like everyone else does, by using pull requests, you'd at least avoid breaking the build due to forgetting to commit everything, and you'd get your changes tested on all of our platforms by the pull tester. I don't see any reason for you not to do at least do that much, and I thought that that's what you had previously agreed to start doing.

I did agree to the release process, which is what we did.

I do several commits a day, this easily moves into hundreds for each cycle. Is anyone going to review them?
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On Sunday, January 06, 2013 17:45:27 Walter Bright wrote:
> On 1/6/2013 5:08 PM, Jonathan M Davis wrote:
> > Even if you were merging all of your pull requests for dmd yourself rather than waiting for reviews like everyone else does, by using pull requests, you'd at least avoid breaking the build due to forgetting to commit everything, and you'd get your changes tested on all of our platforms by the pull tester. I don't see any reason for you not to do at least do that much, and I thought that that's what you had previously agreed to start doing.
> I did agree to the release process, which is what we did.
> 
> I do several commits a day, this easily moves into hundreds for each cycle. Is anyone going to review them?

Ideally, yes. In reality, it would probably be a problem. We have plenty of problems with reviews being a bottleneck already.

However, even if no one else reviews your pull requests, simply going through the process of creating a pull request and letting the pull tester test it will prevent problems involving files being forgotten or breaking platforms that you don't necessarily test on. And if you _do_ test them all already, then maybe the pull request will save you some of that effort. But it doesn't seem to be all that uncommon that you end up having to make commits to unbreak the build because you forgot to commit a file. And using pull requests would catch all that sort of stuff. It would also make sure that it's all working on machines other than your own.

- Jonathan M Davis
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 1/6/2013 5:45 PM, Walter Bright wrote:
> 
> On 1/6/2013 5:08 PM, Jonathan M Davis wrote:
>> Even if you were merging all of your pull requests for dmd yourself rather than waiting for reviews like everyone else does, by using pull requests, you'd at least avoid breaking the build due to forgetting to commit everything, and you'd get your changes tested on all of our platforms by the pull tester. I don't see any reason for you not to do at least do that much, and I thought that that's what you had previously agreed to start doing.
> 
> I did agree to the release process, which is what we did.
> 
> I do several commits a day, this easily moves into hundreds for each cycle. Is anyone going to review them?

1) # commits != # pulls

2) I look at nearly every one of them already, though most I don't feel qualified to comment on.

3) There's more value to pull requests than just human review, the auto-tester adds value too.

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 1/6/2013 5:52 PM, Jonathan M Davis wrote:
> Ideally, yes. In reality, it would probably be a problem. We have plenty of problems with reviews being a bottleneck already. However, even if no one else reviews your pull requests, simply going through the process of creating a pull request and letting the pull tester test it will prevent problems involving files being forgotten or breaking platforms that you don't necessarily test on. And if you _do_ test them all already, then maybe the pull request will save you some of that effort. But it doesn't seem to be all that uncommon that you end up having to make commits to unbreak the build because you forgot to commit a file. And using pull requests would catch all that sort of stuff. It would also make sure that it's all working on machines other than your own. - Jonathan M Davis

I test on all platforms here except FreeBSD64. I have a nice build farm in the basement :-)

Yeah, I forget to push a file once in a while. And then I fix it.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals