Branch: refs/heads/dmd-1.x
  Home:   https://github.com/D-Programming-Language/dmd
  Commit: ef553e41ef1fe0bdf10ba7f830efa9a7422cbcff
      https://github.com/D-Programming-Language/dmd/commit/ef553e41ef1fe0bdf10ba7f830efa9a7422cbcff
  Author: Walter Bright <walter@walterbright.com>
  Date:   2013-01-23 (Wed, 23 Jan 2013)

  Changed paths:
    M src/backend/backconfig.c
    M src/backend/cdef.h
    M src/backend/cod3.c
    M src/mars.c
    M src/mars.h
    M src/msc.c

  Log Message:
  -----------
  add -gx to add stack smash code

On Jan 24, 2013, at 06:24 AM, GitHub <noreply@github.com> wrote:

> Branch: refs/heads/dmd-1.x
> Home: https://github.com/D-Programming-Language/dmd
> Commit: ef553e41ef1fe0bdf10ba7f830efa9a7422cbcff
> https://github.com/D-Programming-Language/dmd/commit/ef553e41ef1fe0bdf10ba7f830efa9a7422cbcff
> Author: Walter Bright <walter@walterbright.com>
> Date: 2013-01-23 (Wed, 23 Jan 2013)
>
> Changed paths:
> M src/backend/backconfig.c
> M src/backend/cdef.h
> M src/backend/cod3.c
> M src/mars.c
> M src/mars.h
> M src/msc.c
>
> Log Message:
> -----------
> add -gx to add stack smash code

I don't understand this. You create a pull request but at the same time you commit the same changes. Although this is to the D1 branch which is not supported any more. Did you want to try it out in the D1 branch first? You have your own fork and local clone to do that.

--
/Jacob Carlborg

On 1/24/2013 1:03 AM, Jacob Carlborg wrote:
>
> I don't understand this. You create a pull request but at the same time you commit the same changes. Although this is to the D1 branch which is not supported any more. Did you want to try it out in the D1 branch first? You have your own fork and local clone to do that.


I added it to D1 to keep it compiling. I also do not intend to do the new pull/review thing with D1, just with D2.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 24 jan 2013, at 11:57, Walter Bright <walter@digitalmars.com> wrote:

> I added it to D1 to keep it compiling. I also do not intend to do the new pull/review thing with D1, just with D2.


Not a big deal but I'm not sure I follow. Why would it not compiler for D1, there are two separate branches?

-- 
/Jacob Carlborg

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals