[Issue 14905] duplicate error message: 'Warning: statement is not reachable'

Aug 11, 2015

Kenji Hara

Aug 11, 2015

Aug 11, 2015

Oct 10, 2022

Oct 10, 2022

Oct 23, 2022

Oct 23, 2022

Nov 01, 2022

Nov 01, 2022

Dec 17, 2022

Jun 10, 2023

https://issues.dlang.org/show_bug.cgi?id=14905 --- Comment #1 from Kenji Hara <k.hara.pg@gmail.com> --- They're not true duplication. If the error messages print their enclosing functions, the messages will be: main.d(3): Warning: statement is not reachable in 'main.fun!"a".fun' main.d(3): Warning: statement is not reachable in 'main.fun!"b".fun' --

August 11, 2015

[Issue 14905] duplicate error message: 'Warning: statement is not reachable'

Posted by Timothee Cour

Permalink

Timothee Cour

Permalink

https://issues.dlang.org/show_bug.cgi?id=14905

Timothee Cour <timothee.cour2@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |timothee.cour2@gmail.com

--- Comment #2 from Timothee Cour <timothee.cour2@gmail.com> ---
(In reply to Kenji Hara from comment #1)
> They're not true duplication. If the error messages print their enclosing functions, the messages will be:
> 
> main.d(3): Warning: statement is not reachable in 'main.fun!"a".fun'
> main.d(3): Warning: statement is not reachable in 'main.fun!"b".fun'

But it doesn't.
Either way, that's a technicality, it's the same root cause and should not
result in dups.

Here's the message that prompted me to file this bug:

inifiled/source/inifiled.d(33): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable
inifiled/source/inifiled.d(42): Warning: statement is not reachable


when compiling Dscanner with local modification to get latest libdparse.

--

https://issues.dlang.org/show_bug.cgi?id=14905 --- Comment #3 from Kenji Hara <k.hara.pg@gmail.com> --- (In reply to Timothee Cour from comment #2) > (In reply to Kenji Hara from comment #1) > > They're not true duplication. If the error messages print their enclosing functions, the messages will be: > > > > main.d(3): Warning: statement is not reachable in 'main.fun!"a".fun' > > main.d(3): Warning: statement is not reachable in 'main.fun!"b".fun' > > But it doesn't. > Either way, that's a technicality, it's the same root cause and should not > result in dups. Technically they're not dup. The two errors come from two different instantiated functions. So, I think the two errors should not be merged into one. --

https://issues.dlang.org/show_bug.cgi?id=14905 RazvanN <razvan.nitu1305@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |razvan.nitu1305@gmail.com --- Comment #4 from RazvanN <razvan.nitu1305@gmail.com> --- I agree with Kenji, those are technically different error messages. There is no way to fix this that would not impact warnings in conditional compilation. What we can do though is add the name of the template instance in the error message as to disambiguate. PR: https://github.com/dlang/dmd/pull/14543 --

https://issues.dlang.org/show_bug.cgi?id=14905 --- Comment #5 from Dlang Bot <dlang-bot@dlang.rocks> --- dlang/dmd pull request #14588 "Revert "Fix Issue 14905 - duplicate error message: 'Warning: statement is not…"" was merged into stable: - 9da58efc5c9656a812ace267c24af7625e4011ee by Iain Buclaw: Revert "Fix Issue 14905 - duplicate error message: 'Warning: statement is not reachable' (#14543)" This reverts commit aae2fd363f56500ce3c17d6ae98524c724132435. https://github.com/dlang/dmd/pull/14588 --

https://issues.dlang.org/show_bug.cgi?id=14905 Iain Buclaw <ibuclaw@gdcproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |ibuclaw@gdcproject.org Resolution|FIXED |--- --- Comment #6 from Iain Buclaw <ibuclaw@gdcproject.org> --- PR was reverted. --

https://issues.dlang.org/show_bug.cgi?id=14905 --- Comment #7 from Dlang Bot <dlang-bot@dlang.rocks> --- @ibuclaw created dlang/dmd pull request #14609 "merge stable" mentioning this issue: - Revert "Fix Issue 14905 - duplicate error message: 'Warning: statement is not reachable' (#14543)" This reverts commit aae2fd363f56500ce3c17d6ae98524c724132435. https://github.com/dlang/dmd/pull/14609 --

https://issues.dlang.org/show_bug.cgi?id=14905 --- Comment #8 from Dlang Bot <dlang-bot@dlang.rocks> --- dlang/dmd pull request #14609 "merge stable" was merged into master: - 12485385f1b8bfbe02f65785b9e43013e534b750 by Iain Buclaw: Revert "Fix Issue 14905 - duplicate error message: 'Warning: statement is not reachable' (#14543)" This reverts commit aae2fd363f56500ce3c17d6ae98524c724132435. https://github.com/dlang/dmd/pull/14609 --

Forums