Thread overview
[Issue 18235] Group logically similar tests into the same module in the D2 testsuite
Jan 14, 2018
Iain Buclaw
Jan 14, 2018
Seb
Apr 05, 2018
Seb
Jun 19, 2020
Walter Bright
Jan 12, 2022
Dennis
Jan 13, 2022
Iain Buclaw
Dec 17, 2022
Iain Buclaw
January 14, 2018
https://issues.dlang.org/show_bug.cgi?id=18235

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |trivial
                 CC|                            |ibuclaw@gdcproject.org

--
January 14, 2018
https://issues.dlang.org/show_bug.cgi?id=18235

Seb <greensunny12@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bootcamp
                 CC|                            |greensunny12@gmail.com

--
April 05, 2018
https://issues.dlang.org/show_bug.cgi?id=18235

--- Comment #1 from Seb <greensunny12@gmail.com> ---
Not saying anything about the logical grouping, but this is a bit exaggerated imho:

> Each new file added to the testsuite may as well be adding 5 seconds onto the overall runtime.

_All_ 1283 fail_compilation tests compile in ~11s on my machine.
The 774 compilable tests are slightly slower with ~25s ... and you don't want
to know how long runnable takes :/
(of course the numbers are taken with full parallelism on an i7 4th Gen)

Anyhow, if someone wants to make the testsuite faster, the runnable tests are the real bad boys and should be focussed on first.

--
June 19, 2020
https://issues.dlang.org/show_bug.cgi?id=18235

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |TestSuite
                 CC|                            |bugzilla@digitalmars.com

--
May 20, 2021
https://issues.dlang.org/show_bug.cgi?id=18235

moonlightsentinel@disroot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |moonlightsentinel@disroot.o
                   |                            |rg

--- Comment #2 from moonlightsentinel@disroot.org ---
Grouping test files doesn't achieve much in regard to the general test execution time. The real time sink are the permutations for DMD's optimizer/inliner (compare `./run.d` with `./run.d quick`)

--
January 12, 2022
https://issues.dlang.org/show_bug.cgi?id=18235

Eddy Schauman-Haigh <hey@eddy.sh> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hey@eddy.sh

--- Comment #3 from Eddy Schauman-Haigh <hey@eddy.sh> ---
Hi! I'm looking to contribute to D and have experience as an SDET so this issue looks perfect. However, from the comments and age of the issue, it's not clear if this is still required. Is it a genuine open issue?

--
January 12, 2022
https://issues.dlang.org/show_bug.cgi?id=18235

Dennis <dkorpel@live.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dkorpel@live.nl

--- Comment #4 from Dennis <dkorpel@live.nl> ---
(In reply to Eddy Schauman-Haigh from comment #3)
> However, from the comments and age of the issue, it's
> not clear if this is still required. Is it a genuine open issue?

Yes, it's still an open issue, the test suite has only grown since. Contributions are appreciated! You can find the test suite here:

https://github.com/dlang/dmd/tree/master/test

--
January 12, 2022
https://issues.dlang.org/show_bug.cgi?id=18235

--- Comment #5 from Eddy Schauman-Haigh <hey@eddy.sh> ---
(In reply to Dennis from comment #4)
> (In reply to Eddy Schauman-Haigh from comment #3)
> > However, from the comments and age of the issue, it's
> > not clear if this is still required. Is it a genuine open issue?
> 
> Yes, it's still an open issue, the test suite has only grown since. Contributions are appreciated! You can find the test suite here:
> 
> https://github.com/dlang/dmd/tree/master/test

Great! In which case I'll start having a look at this issue. Thanks for the swift reply Dennis!

--
January 13, 2022
https://issues.dlang.org/show_bug.cgi?id=18235

--- Comment #6 from Iain Buclaw <ibuclaw@gdcproject.org> ---
Just be sure to benchmark, benchmark, and benchmark some more!

Things that have changed since the original raising of this include:

- Running the most expensive tests first had reduced the time it took to
complete by about a minute when using parallelism.
- Fail compilation tests no longer run with all permutations.
- Neither do compilable tests.

--
December 17, 2022
https://issues.dlang.org/show_bug.cgi?id=18235

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P4

--