[Issue 24417] core.sys.posix.sys.select: fds_bits named __fds_bits on FreeBSD

https://issues.dlang.org/show_bug.cgi?id=24417 Dlang Bot <dlang-bot@dlang.rocks> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |pull --- Comment #1 from Dlang Bot <dlang-bot@dlang.rocks> --- @jmdavis created dlang/dmd pull request #16261 "Fix bugzilla issue 24417: fds_bits named incorrectly on FreeBSD" fixing this issue: - Fix bugzilla issue 24417: fds_bits named incorrectly on FreeBSD This fixes the name of fds_bits on FreeBSD - or actually, on all of the BSDs listed in select.d. The way that they're declared in C is with a member named __fds_bits and then a #define for fds_bits. The D declarations managed to copy the struct declarations with the __ name but didn't add aliases to correspond to the #defines. The standard name is fds_bits and is what any user code should be using, so I don't see any reason to have the __ versions other than to avoid breaking any code that used the __ versions, because that's what was there. So, I fixed the names and added deprecated aliases for the old ones. https://github.com/dlang/dmd/pull/16261 --

February 28

Posted by Dlang Bot

Permalink

Dlang Bot

Permalink

https://issues.dlang.org/show_bug.cgi?id=24417

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #16261 "Fix bugzilla issue 24417: fds_bits named incorrectly on FreeBSD" was merged into master:

- fb40dcf8668af10eb6bc59c5455e2f705c61532d by Jonathan M Davis:
  Fix bugzilla issue 24417: fds_bits named incorrectly on FreeBSD

  This fixes the name of fds_bits on FreeBSD - or actually, on all of the
  BSDs listed in select.d. The way that they're declared in C is with a
  member named __fds_bits and then a #define for fds_bits. The D
  declarations managed to copy the struct declarations with the __ name
  but didn't add aliases to correspond to the #defines.

  The standard name is fds_bits and is what any user code should be using,
  so I don't see any reason to have the __ versions other than to avoid
  breaking any code that used the __ versions, because that's what was
  there. So, I fixed the names and added deprecated aliases for the old
  ones.

https://github.com/dlang/dmd/pull/16261

--

Forums