Menu
Search

Forums

Forum Index

Thread overview
(De)Duplication of information in DRuntime
Oct 02, 2021
Brian
Oct 10, 2021
IGotD-
Nov 28, 2021
Walter Bright
October 02, 2021
Gravatar of BrianPosted by BrianReply
Brian
Gravatar of Brian


Reply

Hello all --

I posted a DRuntime PR (https://github.com/dlang/druntime/pull/3577) syncing OpenBSD dlfcn.h defines.

I noticed that some of this dlfcn information is both in the OS-specific dlfcn.d file and the POSIX dlfcn.d file. Worse still, the OpenBSD-specific version of dlfcn.d is markedly different than the FreeBSD and NetBSD specific versions of dlfcn.d. The FreeBSD and NetBSD specific versions of dlfcn.d duplicate information that appears in the POSIX dlfcn.d file (e.g., the Dl_info struct) whereas the OpenBSD version does not have (as much) duplication of effort.

That leads to a few questions...

  1. Is there some sort of standard rule for which duplicated effort wins?
  2. Is deduplication desirable?
  3. (and most immediately important) Should I be keeping my PR as-is or should I make the OpenBSD dlfcn.d look more like the FreeBSD and NetBSD versions?

Thanks.

~Brian

October 10, 2021
Gravatar of IGotD-Posted by IGotD-
in reply to Brian		Reply
IGotD-
Gravatar of IGotD-
Posted in reply to Brian


Reply

On Saturday, 2 October 2021 at 18:25:16 UTC, Brian wrote:

>

That leads to a few questions...

  1. Is there some sort of standard rule for which duplicated effort wins?

No, there isn't such rule. DRuntime OS dependent code is currently chaotic. I posted previously that I wanted an API for the OS dependent stuff and OS dependent code must be in their own files.

>
  1. Is deduplication desirable?

No, it isn't.

>
  1. (and most immediately important) Should I be keeping my PR as-is or should I make the OpenBSD dlfcn.d look more like the FreeBSD and NetBSD versions?

I think we should use a generic version as much possible. This means that each OS can have it's own dlfcn.d file but if POSIX can be used this file should include the generic POSIX dlfcn.d file.

We can have multiple dlfcn.d files but implementation should be moved to the generic one as much as possible.

November 28, 2021
Gravatar of Walter BrightPosted by Walter Bright
in reply to Brian		Reply
Walter Bright
Gravatar of Walter Bright
Posted in reply to Brian


Reply
The general idea for OS-specific files is to *not* attempt to merge them.

The problem with merging them, is when someone doing a PR for, say, Linux, changes something in the common part, they can (and inevitably will) silently and disastrously break some other OS.

Hence, PRs for Linux headers should *only* affect Linux systems.

This works because Linux headers are never used by FreeBSD systems, even if they have identical sections.