I've cloned Phobos just a few minutes ago, and I've tried to build it with unittests, I'm getting these:

Warning: AutoImplement!(C_6) ignored variadic arguments to the constructor C_6(...)
 --- std.socket(316) broken test ---
 --- std.regex(3671) broken test ---

So what's the procedure now? Do I have to first revert to some earlier version of Phobos that has unittests that pass, before doing any edits? I want to edit an unrelated module and change some code (actually change a unittest), and make a pull request. This is for an already reported bug in bugzilla.

Also, David, your multithreaded unittest is gonna fry my CPU! It's getting hot these days.. :)

On 24.05.2011 1:33, Andrej Mitrovic wrote:
> I've cloned Phobos just a few minutes ago, and I've tried to build it with unittests, I'm getting these:
>
> Warning: AutoImplement!(C_6) ignored variadic arguments to the constructor C_6(...)
>   --- std.socket(316) broken test ---
>   --- std.regex(3671) broken test ---

Windows build is polluted by these messages that meant something sometime ago (usually there was a test that failed, and it was commented out for now).
Still it builds quite easily, though I skipped a couple of recent commits.

> So what's the procedure now? Do I have to first revert to some earlier version of Phobos that has unittests that pass, before doing any edits? I want to edit an unrelated module and change some code (actually change a unittest), and make a pull request. This is for an already reported bug in bugzilla.
Check auto-tester first ;)
http://d.puremagic.com/test-results/

-- 
Dmitry Olshansky

Ok so this seems to be the last stable checkout for windows: http://d.puremagic.com/test-results/test_data.ghtml?dataid=63757

For phobos it says:
Head commit:
commit 7ed4331f37edf6c3f433bd71eeaaefe917a6651a

So how do I jump to this commit in git? I can't figure it out from the progit book..

I guess all I needed was git checkout <hash>, or something like that. But I have a different question:

Which branch am I supposed to work on if I want to create a pull request? master, devel or something else?

On 5/24/11 2:37 PM, Andrej Mitrovic wrote:
> Which branch am I supposed to work on if I want to create a pull
> request? master, devel or something else?

master, then create a feature branch for your pull request (»git checkout -b spiffy-new-feature«).

David

On 5/24/11, David Nadlinger <see@klickverbot.at> wrote:
> master, then create a feature branch for your pull request (»git
> checkout -b spiffy-new-feature«).

Ok, but what about the errors in my original post? I should make sure all unittests pass when I make a pull request, right?

If that's required I think I'd have to first checkout an older commit. But I'm not sure which one. There's a bunch of them for dates May 16th and older listed here: http://d.puremagic.com/test-results/platform-history.ghtml?os=Win_32

E.g. this one: http://d.puremagic.com/test-results/test_data.ghtml?dataid=62436 It says:
>From git://github.com/D-Programming-Language/phobos
   3b628ae..d1d8124  master     -> origin/master

I'm not sure what 3b628ae..d1d8124 means, should I do "git checkout d1d8124" or something similar to get this commit?

> On 5/24/11, David Nadlinger <see@klickverbot.at> wrote:
> > master, then create a feature branch for your pull request (»git
> > checkout -b spiffy-new-feature«).
> 
> Ok, but what about the errors in my original post? I should make sure all unittests pass when I make a pull request, right?
> 
> If that's required I think I'd have to first checkout an older commit. But I'm not sure which one. There's a bunch of them for dates May 16th and older listed here: http://d.puremagic.com/test-results/platform-history.ghtml?os=Win_32
> 
> E.g. this one:
> http://d.puremagic.com/test-results/test_data.ghtml?dataid=62436 It says:
> From git://github.com/D-Programming-Language/phobos
> 3b628ae..d1d8124 master -> origin/master
> 
> I'm not sure what 3b628ae..d1d8124 means, should I do "git checkout d1d8124" or something similar to get this commit?

Pull requests should generally be based on the latest code. Just because it passed when dealing with the older code doesn't mean that your changes will pass with the newer code. If the autotester is failing, I'd suggest simply waiting until it's fixed before doing a pull request unless you're certain that your fix is completely unrelated to its failure. If the current code in git is failing, it should generally be fixed fairly quickly. The tests are currently fully passing on Windows. They're failing on the other OSes because of a compiler change which affected std.datetime (due to a bug which causes dmd to run out of memory when compiling the full unit tests with std.datetime included, std.datetime's unit tests aren't currently run on Windows, which is why they're not failing). If you're using dmd 2.053, that shouldn't be a problem, and Don has a fix prepared for the bug, so the autotester should be passing again soon.

Regardless, I wouldn't advise making changes based on old code. They're less likely to be correct and more likely to cause merge issues.

- Jonathan M Davis

> I guess all I needed was git checkout <hash>, or something like that. But I have a different question:
> 
> Which branch am I supposed to work on if I want to create a pull request? master, devel or something else?

Generally what I do is create a separate branch for whatever I'm working on. When I'm ready to do a pull request, I push it to a branch on github and do the pull request from there. I always leave master on my machine so that it matches the master in the main repository, so it's easy to build whatever the current official code is.

- Jonathan M Davis

On 5/24/11, Jonathan M Davis <jmdavisProg@gmx.com> wrote:
> The tests are
> currently fully passing on Windows.

But the thing is, the autotester uses a changeset dated May 22nd, but the latest changeset on github (https://github.com/D-Programming-Language/phobos) is May 16th, and that is the one I've cloned from and it has failing unittests.

So I'm not sure where to go from there.