Well my editor automatically converts everything to unix LF when saving a file. I think this is the standard for Phobos and dpl.org libs, right? If not, I'll set the editor to just follow whatever line endings a file has.

It also converts tabs to spaces as well. I think I did see some mixed use of tabs and spaces in some modules.

*everything = newlines

On 2011-05-24 13:58, Andrej Mitrovic wrote:
> Well my editor automatically converts everything to unix LF when saving a file. I think this is the standard for Phobos and dpl.org libs, right? If not, I'll set the editor to just follow whatever line endings a file has.
> 
> It also converts tabs to spaces as well. I think I did see some mixed use of tabs and spaces in some modules.

Everything is supposed to be using unix line endings, but that doesn't mean that they all do - particularly if it's an older file which isn't edited very often and the person who has generally edited uses Windows. So, it's possible that the file you edited had Windows line endings. Changing it so that it has unix line endings isn't a problem. The only possible issue is that that makes it so that it's not as obvious what the changes you made are.

- Jonathan M Davis

Dmitry Olshansky wrote:
> On 24.05.2011 1:33, Andrej Mitrovic wrote:
>> I've cloned Phobos just a few minutes ago, and I've tried to build it with unittests, I'm getting these:
>>
>> Warning: AutoImplement!(C_6) ignored variadic arguments to the constructor C_6(...)
>>   --- std.socket(316) broken test ---
>>   --- std.regex(3671) broken test ---
> 
> Windows build is polluted by these messages that meant something sometime ago (usually there was a test that failed, and it was commented out for now).

Those messages are still meaningful. They are to remind people that the bugby tests haven't been fixed.
> Still it builds quite easily, though I skipped a couple of recent commits.
Yes, that's the idea.
> 
>> So what's the procedure now? Do I have to first revert to some earlier version of Phobos that has unittests that pass, before doing any edits? I want to edit an unrelated module and change some code (actually change a unittest), and make a pull request. This is for an already reported bug in bugzilla.
> Check auto-tester first ;)
> http://d.puremagic.com/test-results/
>