... pending Martin's approval.

https://d.puremagic.com/issues/show_bug.cgi?id=3490

https://www.bountysource.com/issues/1327154-dmd-never-inlines-functions-that-could-throw

https://d.puremagic.com/issues/show_bug.cgi?id=3490


Andrei

On 18.3.2014. 21:28, Andrei Alexandrescu wrote:
> ... pending Martin's approval.
> 
> https://d.puremagic.com/issues/show_bug.cgi?id=3490
> 
> https://www.bountysource.com/issues/1327154-dmd-never-inlines-functions-that-could-throw
> 
> 
> https://d.puremagic.com/issues/show_bug.cgi?id=3490
> 
> 
> Andrei

I am bookmarking this for times when some client asks why it took so much to change only a few lines of code :)

On 3/18/14, 5:52 PM, luka8088 wrote:
> On 18.3.2014. 21:28, Andrei Alexandrescu wrote:
>> ... pending Martin's approval.
>>
>> https://d.puremagic.com/issues/show_bug.cgi?id=3490
>>
>> https://www.bountysource.com/issues/1327154-dmd-never-inlines-functions-that-could-throw
>>
>>
>> https://d.puremagic.com/issues/show_bug.cgi?id=3490
>>
>>
>> Andrei
>
> I am bookmarking this for times when some client asks why it took so
> much to change only a few lines of code :)
>

Yeah... I even forgot that five years ago I spotted that ThrowStatement didn't override that method. It's good that I didn't "fix" it back then :-)

On 3/18/2014 4:28 PM, Andrei Alexandrescu wrote:
> ... pending Martin's approval.
>
> https://d.puremagic.com/issues/show_bug.cgi?id=3490
>
> https://www.bountysource.com/issues/1327154-dmd-never-inlines-functions-that-could-throw
>

Heh, cool, thanks all :)

Speaking of, I learned a lot about DMD's inliner while doing that, so I've posted an explanation of it on the Wiki:

http://wiki.dlang.org/DMD_Source_Guide#Inliner

Since it's based mainly on what I sussed out from looking at the source, it could probably use a look-over by a DMD guru in case I've misunderstood anything.

On Wednesday, 19 March 2014 at 05:40:22 UTC, Nick Sabalausky wrote:
> On 3/18/2014 4:28 PM, Andrei Alexandrescu wrote:
>> ... pending Martin's approval.
>>
>> https://d.puremagic.com/issues/show_bug.cgi?id=3490
>>
>> https://www.bountysource.com/issues/1327154-dmd-never-inlines-functions-that-could-throw
>>
>
> Heh, cool, thanks all :)
>
> Speaking of, I learned a lot about DMD's inliner while doing that, so I've posted an explanation of it on the Wiki:
>
> http://wiki.dlang.org/DMD_Source_Guide#Inliner
>
> Since it's based mainly on what I sussed out from looking at the source, it could probably use a look-over by a DMD guru in case I've misunderstood anything.

Awesome write-up. Very informative.

On Thursday, 20 March 2014 at 19:12:29 UTC, Brad Anderson wrote:
> On Wednesday, 19 March 2014 at 05:40:22 UTC, Nick Sabalausky wrote:
>> On 3/18/2014 4:28 PM, Andrei Alexandrescu wrote:
>>> ... pending Martin's approval.
>>>
>>> https://d.puremagic.com/issues/show_bug.cgi?id=3490
>>>
>>> https://www.bountysource.com/issues/1327154-dmd-never-inlines-functions-that-could-throw
>>>
>>
>> Heh, cool, thanks all :)
>>
>> Speaking of, I learned a lot about DMD's inliner while doing that, so I've posted an explanation of it on the Wiki:
>>
>> http://wiki.dlang.org/DMD_Source_Guide#Inliner
>>
>> Since it's based mainly on what I sussed out from looking at the source, it could probably use a look-over by a DMD guru in case I've misunderstood anything.
>
> Awesome write-up. Very informative.

+1

Imagine if the whole of the compiler/runtime was documented this well...

On 3/19/14, Nick Sabalausky <SeeWebsiteToContactMe@semitwist.com> wrote:
> Speaking of, I learned a lot about DMD's inliner while doing that, so I've posted an explanation of it on the Wiki:
>
> http://wiki.dlang.org/DMD_Source_Guide#Inliner

I was really impressed by the write-up. I never touched the inliner before so these docs come in very handy. Thanks a bunch for this!

On 3/20/2014 3:27 PM, John Colvin wrote:
> On Thursday, 20 March 2014 at 19:12:29 UTC, Brad Anderson wrote:
>> On Wednesday, 19 March 2014 at 05:40:22 UTC, Nick Sabalausky wrote:
>>>
>>> Speaking of, I learned a lot about DMD's inliner while doing that, so
>>> I've posted an explanation of it on the Wiki:
>>>
>>> http://wiki.dlang.org/DMD_Source_Guide#Inliner
>>>
>>> Since it's based mainly on what I sussed out from looking at the
>>> source, it could probably use a look-over by a DMD guru in case I've
>>> misunderstood anything.
>>
>> Awesome write-up. Very informative.
>
> +1
>
> Imagine if the whole of the compiler/runtime was documented this well...

Glad to hear it's well-received!

I highly encourage anyone who's first diving into an unfamiliar section of DMD or druntime to post what they've learned to the Wiki:

I think that's a prime time to do so, when the new knowledge is still fresh in your mind. It really helps you digest all of it and identify any unexpected gaps in your own knowledge. Plus, others can help correct any misunderstandings, and any aspects of the code that turn out to be difficult for newcomers to grasp can be better identified.

On Wednesday, 19 March 2014 at 05:40:22 UTC, Nick Sabalausky wrote:
> On 3/18/2014 4:28 PM, Andrei Alexandrescu wrote:
>> ... pending Martin's approval.
>>
>> https://d.puremagic.com/issues/show_bug.cgi?id=3490
>>
>> https://www.bountysource.com/issues/1327154-dmd-never-inlines-functions-that-could-throw
>>
>
> Heh, cool, thanks all :)
>
> Speaking of, I learned a lot about DMD's inliner while doing that, so I've posted an explanation of it on the Wiki:
>
> http://wiki.dlang.org/DMD_Source_Guide#Inliner
>
> Since it's based mainly on what I sussed out from looking at the source, it could probably use a look-over by a DMD guru in case I've misunderstood anything.

That is awesome ! I wish I knew this existed earlier !