On 30/10/2024 5:59 AM, Chris Piker wrote:
> What is the etiquette around Bugzilla usage in the community? Would it be appropriate or inappropriate to get an account on issues.dlang.org just to post a comment on a bug stating that it affect my code.

If there is one other person stating just this, sure.

If there is five, maybe not.

It would depend upon the complexity of the fix, the greater the complexity the greater the need for a fix to warrant peoples time.

In this case, it seems more prudent to fix it due to simplicity.

On Tue, Oct 29, 2024 at 04:59:48PM +0000, Chris Piker via Digitalmars-d-learn wrote:
> Hi D
> 
> There is a bug listed in the Bugzilla tracking tool that affected me the other day, [15526](https://issues.dlang.org/show_bug.cgi?id=15526).  It's not a big problem, just an unexpected issue and seems easy to fix... by someone familiar with Phobos.
> 
> What is the etiquette around Bugzilla usage in the community? Would it be appropriate or inappropriate to get an account on issues.dlang.org just to post a comment on a bug stating that it affect my code.
> 
> I haven't done so because I'm presuming you want to keep the issue tracker clean and not let the peanut gallery run amok, thus comments that don't directly affect a patch are inappropriate.  Is that true?

I haven't been involved with Phobos for a while now, so I can't speak for the current conventions, but at least in the past, it was highly encouraged to get a bugzilla account and post issues so that the devs are aware of it.  My own take is, if an issue bothers you, make noise about it, both on bugzilla and here, and that will increase the chances that somebody will hear and take action. (But caveat emptor: I haven't been involved for a while now so I don't know if this is still acceptable.)

As far as this issue itself is concerned, my take on it after a cursory glance is that it's pretty easy to implement; std.format already has extended options for printing numbers with separators, so why not have std.conv provide a similar option as well.  But other commentators on the bugzilla issue seem to have a different opinion, so I don't know. You'd have to convince the right people that it's worth doing.

If that doesn't go through, or if you just can't be bothered with the trouble of getting people's attention and then taking the time and effort to convince them, I'd say just do something like this:

	// This should do the job. Put it in a function if you need it
	// frequently.
	myInput.byChars.filter!(ch => ch != '_').to!int


T

-- 
Last night, I dreamed about my pet rabbits all lined up like in a parade, and hopping backwards.  Then I woke up and realized that it was my receding hare line!

On Tuesday, 29 October 2024 at 19:18:05 UTC, H. S. Teoh wrote:
> 	// This should do the job. Put it in a function if you need it
> 	// frequently.
> 	myInput.byChars.filter!(ch => ch != '_').to!int

That's similar to the workaround I used, but yours uses a lazy range so it's nicer than mine.  Thanks for sharing!

Of course it's a tiny issue, but normally phobos functions are rather predictable so ironing out the final parts of phobos2 seems like a good idea.