Now that https://github.com/dlang/dmd/pull/17057 has been merged are there any obvious applications of it to druntime and phobos?
Thread overview | |||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
March 03 Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
March 03 Re: Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Per Nordlöw | On Monday, 3 March 2025 at 12:40:06 UTC, Per Nordlöw wrote: >Now that https://github.com/dlang/dmd/pull/17057 has been merged are there any obvious applications of it to druntime and phobos? Should all instances of |
March 03 Re: Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Per Nordlöw | On Monday, 3 March 2025 at 13:23:57 UTC, Per Nordlöw wrote: >On Monday, 3 March 2025 at 12:40:06 UTC, Per Nordlöw wrote: >Now that https://github.com/dlang/dmd/pull/17057 has been merged are there any obvious applications of it to druntime and phobos? Should all instances of I think a good first step would be to try replacing the current implementation(s) of |
March 03 Re: Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Paul Backus | On Monday, 3 March 2025 at 15:12:20 UTC, Paul Backus wrote: >I think a good first step would be to try replacing the current implementation(s) of Do you mean doing this before replacing the top-level calls top |
March 04 Re: Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Per Nordlöw | On Monday, 3 March 2025 at 18:57:05 UTC, Per Nordlöw wrote: >On Monday, 3 March 2025 at 15:12:20 UTC, Paul Backus wrote: >I think a good first step would be to try replacing the current implementation(s) of Do you mean doing this before replacing the top-level calls top Yes. |
March 04 Re: Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Paul Backus Attachments:
| On Tue, 4 Mar 2025 at 11:21, Paul Backus via Digitalmars-d < digitalmars-d@puremagic.com> wrote:
> On Monday, 3 March 2025 at 18:57:05 UTC, Per Nordlöw wrote:
> > On Monday, 3 March 2025 at 15:12:20 UTC, Paul Backus wrote:
> >> I think a good first step would be to try replacing the current implementation(s) of `emplace` with calls to placement new.
> >
> > Do you mean doing this before replacing the top-level calls top `emplace`?
>
> Yes.
>
Yes, this.
I've tried this already, and it reveals several implementation edge cases,
which will need to be bugged and resolved.
My plan was to try and replace the function internals with placement new
for as many cases as are working properly, and the code itself will act as
a document detailing which cases are outstanding and need resolution.
Please do contribute to this effort if you're enthusiastic! I have very
little free time rn.
|
March 04 Re: Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Manu | Add features first, think of use cases later! |
March 04 Re: Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Manu | On Tuesday, 4 March 2025 at 01:27:29 UTC, Manu wrote: >Please do contribute to this effort if you're enthusiastic! I have very Tried converting a couple of usages of
as
. This doesn't always work eventough |
March 04 Re: Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to Per Nordlöw Attachments:
| On Tue, 4 Mar 2025 at 21:25, Per Nordlöw via Digitalmars-d < digitalmars-d@puremagic.com> wrote: > On Tuesday, 4 March 2025 at 01:27:29 UTC, Manu wrote: > > Please do contribute to this effort if you're enthusiastic! I > > have very > > little free time rn. > > Tried converting a couple of usages of `emplace` and `moveEmplace` in a repo of mine and discovered that I'm missing a way to express > > `moveEmplace(x, y)` > > as > > `new(y) typeof(y)(__rvalue(x))` > > . This doesn't always work eventough `y` being assignable from `x`. > Is it this issue: https://github.com/dlang/dmd/issues/20950 ?? If not, please post repro so I can investigate. |
March 04 Re: Applying Placement New to druntime and phobos | ||||
---|---|---|---|---|
| ||||
Posted in reply to ryuukk_ Attachments:
| On Tue, 4 Mar 2025 at 20:56, ryuukk_ via Digitalmars-d < digitalmars-d@puremagic.com> wrote:
> Add features first, think of use cases later!
Huh?
|