[Issue 14564] [REG2.067] dmd -property -unittest combination causes compiler error (page 2)

https://issues.dlang.org/show_bug.cgi?id=14564 Walter Bright <bugzilla@digitalmars.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@digitalmars.com --- Comment #8 from Walter Bright <bugzilla@digitalmars.com> --- (In reply to Vladimir Panteleev from comment #3) > -property is going away, but let's see what the maintainers say. > > Introduced in https://github.com/D-Programming-Language/phobos/pull/2723 Any idea which of those 196 lines produced the regression? --

https://issues.dlang.org/show_bug.cgi?id=14564 --- Comment #9 from Илья Ярошенко <ilyayaroshenko@gmail.com> --- (In reply to Walter Bright from comment #8) > (In reply to Vladimir Panteleev from comment #3) > > -property is going away, but let's see what the maintainers say. > > > > Introduced in https://github.com/D-Programming-Language/phobos/pull/2723 > > Any idea which of those 196 lines produced the regression? All lines with call `_ctfeSkipOp` or `_ctfeSkipInteger`. --

https://issues.dlang.org/show_bug.cgi?id=14564 --- Comment #10 from Walter Bright <bugzilla@digitalmars.com> --- (In reply to Илья Ярошенко from comment #9) > (In reply to Walter Bright from comment #8) > > Any idea which of those 196 lines produced the regression? > > All lines with call `_ctfeSkipOp` or `_ctfeSkipInteger`. So, the whole PR? Should we just revert it? --

https://issues.dlang.org/show_bug.cgi?id=14564 --- Comment #11 from Илья Ярошенко <ilyayaroshenko@gmail.com> --- (In reply to Walter Bright from comment #10) > (In reply to Илья Ярошенко from comment #9) > > (In reply to Walter Bright from comment #8) > > > Any idea which of those 196 lines produced the regression? > > > > All lines with call `_ctfeSkipOp` or `_ctfeSkipInteger`. > > So, the whole PR? Should we just revert it? Not only this PR! You need to revert half of Phobos if you want to fix this bug by reverting something. For example, this is line in std.uni: static bool pred(dchar c) {return !c.isWhite && c != '-' && c != '_';} The error (the first in this bug report) occurs because c.isWhite has not braces, not because my PR. We need make the choice: 1. Remove -property option from compiler OR 2. Add the -property option to the GitHub testing engine and fix ALL Phobos. --

July 22, 2015

[Issue 14564] [REG2.067] dmd -property -unittest combination causes compiler error

Posted by Jonathan M Davis

Permalink

Jonathan M Davis

Permalink

https://issues.dlang.org/show_bug.cgi?id=14564

--- Comment #12 from Jonathan M Davis <issues.dlang@jmdavisProg.com> ---
(In reply to Илья Ярошенко from comment #11)
> We need make the choice:
> 1. Remove -property option from compiler
> OR
> 2. Add the -property option to the GitHub testing engine and fix ALL Phobos.

Exactly. And given that even if we want some type of property enforcement, the -property flag is enforcing something that we definitely _don't_ want at this point (that non-@property functions be called with parens), I think that we'd be better off to just remove -property. And presumably, that would mean making it do nothing to begin with rather than simply removing it, but we clearly don't want it, and it seems rather silly to be making a bunch of changes to Phobos at this point to support it (though arguably, whatever PR that removed the -property flag from the Phobos build shouldn't have been pulled as long as -property was still in the compiler, but it's a bit late for that now).

So, personally, I think that the clear choice is to make -property do nothing (except maybe print out a warning about how it now does nothing), but I don't know how much work that would be. Regardless, we have to get rid of it at some point, and if we don't do it now, we need to start building Phobos with -property, and make all of the changes associated with that.

--

https://issues.dlang.org/show_bug.cgi?id=14564 ag0aep6g@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |pull --- Comment #13 from ag0aep6g@gmail.com --- (In reply to Jonathan M Davis from comment #12) > So, personally, I think that the clear choice is to make -property do nothing (except maybe print out a warning about how it now does nothing), but I don't know how much work that would be. PR for that: https://github.com/D-Programming-Language/dmd/pull/4850 --

https://issues.dlang.org/show_bug.cgi?id=14564 --- Comment #14 from ag0aep6g@gmail.com --- (In reply to ag0aep6g from comment #13) > https://github.com/D-Programming-Language/dmd/pull/4850 Superseded by https://github.com/D-Programming-Language/dmd/pull/4862 --

https://issues.dlang.org/show_bug.cgi?id=14564 --- Comment #15 from github-bugzilla@puremagic.com --- Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/1e391e7b7a7a5d088811a7d5b145c783dfb4e356 make -property do nothing fixes issue 14564 - [REG2.067] dmd -property -unittest combination causes compiler error Regarding the removed tests: Issue 8629 occurred with other errors than property errors, too. It would be possible to replace the property error with another one in the test. But Martin Nowak says: "Just remove the test." The test for issue 9241 was about the exact error message for when a non-property is called without parentheses. That's allowed now, even with -property. Removing the test. https://github.com/D-Programming-Language/dmd/commit/05d132b4c15048fb988f6f498ce5ec4bfddb0512 Merge pull request #4862 from aG0aep6G/property-switch-2 issue 14564 - [REG2.067] dmd -property -unittest combination causes compiler error --

Forums