On Sat, Feb 11, 2012 at 3:33 AM, David Nadlinger <code at klickverbot.at> wrote:
> Okay, seems like we have an abundance of modules ready to review, but are lacking review managers. Given that the Thrift/D code is submitted for upstream inclusion and its to-do list is currently empty, I'd be happy to help out ? but which module do we want to review first?

std.log is ready immediate review but I leave it up to you and the D community. Let me know if there is anything I can do to help the process. I would also like to apologies for allowing std.log to stay so long in the queue. Thank you David for volunteering to do this!

-Jose

> std.log has been in
> the queue forever (but was previously postponed due to Jose being
> unavailable), std.uuid is small (but parts of it depend on not-yet-in-Phobos
> hashing code), and Jacob Carlborg is waiting for feedback on Orange?
>
> David
>
>
>
> On 2/9/12 3:31 AM, Andrei Alexandrescu wrote:
>>
>> Who would want to be the review manager for this and UUID?
>>
>> Andrei
>>
>> On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
>>>
>>> Hey all,
>>>
>>> The module std.log is finally ready for review. I would like to put it in the review queue for phobos. Here are some links for your documentation:
>>>
>>> 1. HTML Documentation:
>>> http://jsancio.github.com/phobos/phobos/std_log.html
>>> 2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>>>
>>> The module should work as is with the latest druntime. I would really appreciate it if you can try it and comment on the implementation.
>>>
>>> Thanks,
>>> -Jose
>>> PS. It has been a while since I tested it in Windows but it should
>>> work. I am going to spend some time validating that OS.
>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos

On Sat, Feb 11, 2012 at 11:57 PM, Jose Armando Garcia <jsancio at gmail.com> wrote:
> On Sat, Feb 11, 2012 at 3:33 AM, David Nadlinger <code at klickverbot.at> wrote:
>> Okay, seems like we have an abundance of modules ready to review, but are lacking review managers. Given that the Thrift/D code is submitted for upstream inclusion and its to-do list is currently empty, I'd be happy to help out ? but which module do we want to review first?
>
> std.log is ready immediate review but I leave it up to you and the D community. Let me know if there is anything I can do to help the process. I would also like to apologies for allowing std.log to stay so long in the queue. Thank you David for volunteering to do this!
>

Actually, std.log doesn't even compile against the latest Phobos. I am not sure how long it is going to take me to fix the problem. I'll keep you guys up to date on my progress.

Thanks
-Jose
> -Jose
>
>> std.log has been in
>> the queue forever (but was previously postponed due to Jose being
>> unavailable), std.uuid is small (but parts of it depend on not-yet-in-Phobos
>> hashing code), and Jacob Carlborg is waiting for feedback on Orange?
>>
>> David
>>
>>
>>
>> On 2/9/12 3:31 AM, Andrei Alexandrescu wrote:
>>>
>>> Who would want to be the review manager for this and UUID?
>>>
>>> Andrei
>>>
>>> On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
>>>>
>>>> Hey all,
>>>>
>>>> The module std.log is finally ready for review. I would like to put it in the review queue for phobos. Here are some links for your documentation:
>>>>
>>>> 1. HTML Documentation:
>>>> http://jsancio.github.com/phobos/phobos/std_log.html
>>>> 2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>>>>
>>>> The module should work as is with the latest druntime. I would really appreciate it if you can try it and comment on the implementation.
>>>>
>>>> Thanks,
>>>> -Jose
>>>> PS. It has been a while since I tested it in Windows but it should
>>>> work. I am going to spend some time validating that OS.
>>
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos

On Sat, Feb 11, 2012 at 3:33 AM, David Nadlinger <code at klickverbot.at> wrote:
> Okay, seems like we have an abundance of modules ready to review, but are lacking review managers. Given that the Thrift/D code is submitted for upstream inclusion and its to-do list is currently empty, I'd be happy to help out ? but which module do we want to review first? std.log has been in the queue forever (but was previously postponed due to Jose being unavailable), std.uuid is small (but parts of it depend on not-yet-in-Phobos hashing code), and Jacob Carlborg is waiting for feedback on Orange?
>
> David

Okay David,

std.log is good to go...

Source code: https://github.com/jsancio/phobos/commit/d114420e0791c704f6899d81a0293cbd3cc8e6f5 HTML doc: http://jsancio.github.com/phobos/phobos/std_log.html#minSeverity

Thanks,
-Jose
>
>
>
> On 2/9/12 3:31 AM, Andrei Alexandrescu wrote:
>>
>> Who would want to be the review manager for this and UUID?
>>
>> Andrei
>>
>> On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
>>>
>>> Hey all,
>>>
>>> The module std.log is finally ready for review. I would like to put it in the review queue for phobos. Here are some links for your documentation:
>>>
>>> 1. HTML Documentation:
>>> http://jsancio.github.com/phobos/phobos/std_log.html
>>> 2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>>>
>>> The module should work as is with the latest druntime. I would really appreciate it if you can try it and comment on the implementation.
>>>
>>> Thanks,
>>> -Jose
>>> PS. It has been a while since I tested it in Windows but it should
>>> work. I am going to spend some time validating that OS.
>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos

If you want to be the review manager, just drag your icon to the item you want to manage in trello (I saw you joined the board).? Maybe also put a comment indicating that you are the review manager (there appears to be no way to designate a role for someone in a particular card).? Then when you wish to announce to the NG, just move it to the "In Review" list.

Note that the ordering of lists is pertinent, meaning they aren't in just some random order.? Any new cards added to the ready to review queue should go at the bottom.? I arbitrarily chose the order when I created the std.log and std.uuid cards, so I think it's fine if they got reordered.

I think the agreement was that we would only review one item at a time, but I don't know if that was a mandate from Andrei or a consensus.? Is that what should happen or should we allow more than one review at a time?


-Steve



----- Original Message -----
> From: David Nadlinger <code at klickverbot.at>
> To: phobos at puremagic.com
> Cc:
> Sent: Saturday, February 11, 2012 12:33 AM
> Subject: Re: [phobos] std.log ready for review!
> 
> Okay, seems like we have an abundance of modules ready to review, but are lacking review managers. Given that the Thrift/D code is submitted for upstream inclusion and its to-do list is currently empty, I'd be happy to help out ? but which module do we want to review first? std.log has been in the queue forever (but was previously postponed due to Jose being unavailable), std.uuid is small (but parts of it depend on not-yet-in-Phobos hashing code), and Jacob Carlborg is waiting for feedback on Orange?
> 
> David
> 
> 
> On 2/9/12 3:31 AM, Andrei Alexandrescu wrote:
>>  Who would want to be the review manager for this and UUID?
>> 
>>  Andrei
>> 
>>  On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
>>>  Hey all,
>>> 
>>>  The module std.log is finally ready for review. I would like to put it
>>>  in the review queue for phobos. Here are some links for your
>>>  documentation:
>>> 
>>>  1. HTML Documentation:
>>>  http://jsancio.github.com/phobos/phobos/std_log.html
>>>  2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>>> 
>>>  The module should work as is with the latest druntime. I would really
>>>  appreciate it if you can try it and comment on the implementation.
>>> 
>>>  Thanks,
>>>  -Jose
>>>  PS. It has been a while since I tested it in Windows but it should
>>>  work. I am going to spend some time validating that OS.
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
> 

Yep, I updated Trello as well now ? just wanted to make sure that nobody on the list was already expecting to see another module reviewed first, etc.

As for concurrent reviews, I'm not sure what is the better choice, for the obvious reasons (diluting attention vs. avoiding long wits for review). If the rate of Phobos submissions will go up, the question will certainly become more important.

David



On 2/13/12 2:55 PM, Steve Schveighoffer wrote:
> If you want to be the review manager, just drag your icon to the item you want to manage in trello (I saw you joined the board).  Maybe also put a comment indicating that you are the review manager (there appears to be no way to designate a role for someone in a particular card).  Then when you wish to announce to the NG, just move it to the "In Review" list.
>
> Note that the ordering of lists is pertinent, meaning they aren't in just some random order.  Any new cards added to the ready to review queue should go at the bottom.  I arbitrarily chose the order when I created the std.log and std.uuid cards, so I think it's fine if they got reordered.
>
> I think the agreement was that we would only review one item at a time, but I don't know if that was a mandate from Andrei or a consensus.  Is that what should happen or should we allow more than one review at a time?
>
>
> -Steve