Hey all,

The module std.log is finally ready for review. I would like to put it in the review queue for phobos. Here are some links for your documentation:

1. HTML Documentation: http://jsancio.github.com/phobos/phobos/std_log.html 2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d

The module should work as is with the latest druntime. I would really appreciate it if you can try it and comment on the implementation.

Thanks,
-Jose
PS. It has been a while since I tested it in Windows but it should
work. I am going to spend some time validating that OS.

Am 07.02.2012 14:02, schrieb Jose Armando Garcia:
> Hey all,
>
> The module std.log is finally ready for review. I would like to put it in the review queue for phobos.
The review queue has a wiki page now: http://prowiki.org/wiki4d/wiki.cgi?ReviewQueue

I added std.log for you. If you want to have std.log reviewed before std.uuid I'm fine with that.

-- 
Johannes Pfau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puremagic.com/pipermail/phobos/attachments/20120208/1c8aa857/attachment.html>

On Wed, Feb 8, 2012 at 3:47 PM, Johannes Pfau
<johannespfau at googlemail.com> wrote:
> Am 07.02.2012 14:02, schrieb Jose Armando Garcia:
>
> Hey all,
>
> The module std.log is finally ready for review. I would like to put it in the review queue for phobos.
>
> The review queue has a wiki page now: http://prowiki.org/wiki4d/wiki.cgi?ReviewQueue
>
> I added std.log for you. If you want to have std.log reviewed before std.uuid I'm fine with that.
>

Cool. Thanks! I am okay either way. It is really up to the review manager and the mailing list...

> --
> Johannes Pfau
>
>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos

Who would want to be the review manager for this and UUID?

Andrei

On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
> Hey all,
>
> The module std.log is finally ready for review. I would like to put it in the review queue for phobos. Here are some links for your documentation:
>
> 1. HTML Documentation: http://jsancio.github.com/phobos/phobos/std_log.html 2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>
> The module should work as is with the latest druntime. I would really appreciate it if you can try it and comment on the implementation.
>
> Thanks,
> -Jose
> PS. It has been a while since I tested it in Windows but it should
> work. I am going to spend some time validating that OS.
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos

I'll point out that we should be using trello for this.? I'll look at making a "Proposed enhancements" board for phobos.


-Steve



----- Original Message -----
> From: Andrei Alexandrescu <andrei at erdani.com>
> To: Discuss the phobos library for D <phobos at puremagic.com>
> Cc:
> Sent: Wednesday, February 8, 2012 9:31 PM
> Subject: Re: [phobos] std.log ready for review!
> 
> Who would want to be the review manager for this and UUID?
> 
> Andrei
> 
> On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
>>  Hey all,
>> 
>>  The module std.log is finally ready for review. I would like to put it
>>  in the review queue for phobos. Here are some links for your
>>  documentation:
>> 
>>  1. HTML Documentation: http://jsancio.github.com/phobos/phobos/std_log.html
>>  2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>> 
>>  The module should work as is with the latest druntime. I would really
>>  appreciate it if you can try it and comment on the implementation.
>> 
>>  Thanks,
>>  -Jose
>>  PS. It has been a while since I tested it in Windows but it should
>>  work. I am going to spend some time validating that OS.
>>  _______________________________________________
>>  phobos mailing list
>>  phobos at puremagic.com
>>  http://lists.puremagic.com/mailman/listinfo/phobos
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
> 

OK, did that. boy, trello is easy to use :)

Jose and Johannes, can you create trello user ids?

I'm envisioning the review manager adds themselves to the card, then moves the card to "in review" where the NG comments occur.? If any comments result in further development required, those get added as a checklist, then it goes back to development.? Finally, if it goes to a vote, we use the NG to tally the votes, report, and move it to the accepted or rejected list.? If it goes to accepted, then the developer creates a pull request, and when it's implemented, the card is archived.

Sound good?

-Steve



----- Original Message -----
> From: Steve Schveighoffer <schveiguy at yahoo.com>
> To: Discuss the phobos library for D <phobos at puremagic.com>
> Cc:
> Sent: Thursday, February 9, 2012 8:48 AM
> Subject: Re: [phobos] std.log ready for review!
> 
> I'll point out that we should be using trello for this.? I'll look at making a "Proposed enhancements" board for phobos.
> 
> 
> -Steve
> 
> 
> 
> ----- Original Message -----
>>  From: Andrei Alexandrescu <andrei at erdani.com>
>>  To: Discuss the phobos library for D <phobos at puremagic.com>
>>  Cc:
>>  Sent: Wednesday, February 8, 2012 9:31 PM
>>  Subject: Re: [phobos] std.log ready for review!
>> 
>>  Who would want to be the review manager for this and UUID?
>> 
>>  Andrei
>> 
>>  On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
>>> ? Hey all,
>>> 
>>> ? The module std.log is finally ready for review. I would like to put it
>>> ? in the review queue for phobos. Here are some links for your
>>> ? documentation:
>>> 
>>> ? 1. HTML Documentation:
> http://jsancio.github.com/phobos/phobos/std_log.html
>>> ? 2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>>> 
>>> ? The module should work as is with the latest druntime. I would really ? appreciate it if you can try it and comment on the implementation.
>>> 
>>> ? Thanks,
>>> ? -Jose
>>> ? PS. It has been a while since I tested it in Windows but it should
>>> ? work. I am going to spend some time validating that OS.
>>> ? _______________________________________________
>>> ? phobos mailing list
>>> ? phobos at puremagic.com
>>> ? http://lists.puremagic.com/mailman/listinfo/phobos
>>  _______________________________________________
>>  phobos mailing list
>>  phobos at puremagic.com
>>  http://lists.puremagic.com/mailman/listinfo/phobos
>> 
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
> 

On Thu, Feb 9, 2012 at 12:18 PM, Steve Schveighoffer <schveiguy at yahoo.com> wrote:
> OK, did that. boy, trello is easy to use :)
>
> Jose and Johannes, can you create trello user ids?
>

Thanks, my username is jsancio. I assume that I need to join the D organization.

> I'm envisioning the review manager adds themselves to the card, then moves the card to "in review" where the NG comments occur.? If any comments result in further development required, those get added as a checklist, then it goes back to development.? Finally, if it goes to a vote, we use the NG to tally the votes, report, and move it to the accepted or rejected list.? If it goes to accepted, then the developer creates a pull request, and when it's implemented, the card is archived.
>
> Sound good?
>
> -Steve
>
>
>
> ----- Original Message -----
>> From: Steve Schveighoffer <schveiguy at yahoo.com>
>> To: Discuss the phobos library for D <phobos at puremagic.com>
>> Cc:
>> Sent: Thursday, February 9, 2012 8:48 AM
>> Subject: Re: [phobos] std.log ready for review!
>>
>> I'll point out that we should be using trello for this.? I'll look at making a "Proposed enhancements" board for phobos.
>>
>>
>> -Steve
>>
>>
>>
>> ----- Original Message -----
>>> ?From: Andrei Alexandrescu <andrei at erdani.com>
>>> ?To: Discuss the phobos library for D <phobos at puremagic.com>
>>> ?Cc:
>>> ?Sent: Wednesday, February 8, 2012 9:31 PM
>>> ?Subject: Re: [phobos] std.log ready for review!
>>>
>>> ?Who would want to be the review manager for this and UUID?
>>>
>>> ?Andrei
>>>
>>> ?On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
>>>> ? Hey all,
>>>>
>>>> ? The module std.log is finally ready for review. I would like to put it
>>>> ? in the review queue for phobos. Here are some links for your
>>>> ? documentation:
>>>>
>>>> ? 1. HTML Documentation:
>> http://jsancio.github.com/phobos/phobos/std_log.html
>>>> ? 2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>>>>
>>>> ? The module should work as is with the latest druntime. I would really ? appreciate it if you can try it and comment on the implementation.
>>>>
>>>> ? Thanks,
>>>> ? -Jose
>>>> ? PS. It has been a while since I tested it in Windows but it should
>>>> ? work. I am going to spend some time validating that OS.
>>>> ? _______________________________________________
>>>> ? phobos mailing list
>>>> ? phobos at puremagic.com
>>>> ? http://lists.puremagic.com/mailman/listinfo/phobos
>>> ?_______________________________________________
>>> ?phobos mailing list
>>> ?phobos at puremagic.com
>>> ?http://lists.puremagic.com/mailman/listinfo/phobos
>>>
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos
>>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos

You actually must be invited I think to join the organization (I'll see if I can do that), but I can add you as a member of the board even if you are not a member of the D organization (done).

Thanks

-Steve



----- Original Message -----
> From: Jose Armando Garcia <jsancio at gmail.com>
> To: Steve Schveighoffer <schveiguy at yahoo.com>; Discuss the phobos library for D <phobos at puremagic.com>
> Cc:
> Sent: Thursday, February 9, 2012 9:38 AM
> Subject: Re: [phobos] std.log ready for review!
> 
> On Thu, Feb 9, 2012 at 12:18 PM, Steve Schveighoffer <schveiguy at yahoo.com> wrote:
>>  OK, did that. boy, trello is easy to use :)
>> 
>>  Jose and Johannes, can you create trello user ids?
>> 
> 
> Thanks, my username is jsancio. I assume that I need to join the D organization.

Am 09.02.2012 15:18, schrieb Steve Schveighoffer:
> OK, did that. boy, trello is easy to use :)
>
> Jose and Johannes, can you create trello user ids?
>
> I'm envisioning the review manager adds themselves to the card, then moves the card to "in review" where the NG comments occur.  If any comments result in further development required, those get added as a checklist, then it goes back to development.  Finally, if it goes to a vote, we use the NG to tally the votes, report, and move it to the accepted or rejected list.  If it goes to accepted, then the developer creates a pull request, and when it's implemented, the card is archived.
>
> Sound good?
>
> -Steve
<https://trello.com/jpf>Sounds good.
My trello username is 'jpf' (https://trello.com/jpf)
<https://trello.com/jpf>

-- 
Johannes Pfau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puremagic.com/pipermail/phobos/attachments/20120209/31608706/attachment-0001.html>

Okay, seems like we have an abundance of modules ready to review, but are lacking review managers. Given that the Thrift/D code is submitted for upstream inclusion and its to-do list is currently empty, I'd be happy to help out ? but which module do we want to review first? std.log has been in the queue forever (but was previously postponed due to Jose being unavailable), std.uuid is small (but parts of it depend on not-yet-in-Phobos hashing code), and Jacob Carlborg is waiting for feedback on Orange?

David


On 2/9/12 3:31 AM, Andrei Alexandrescu wrote:
> Who would want to be the review manager for this and UUID?
>
> Andrei
>
> On 2/7/12 5:02 AM, Jose Armando Garcia wrote:
>> Hey all,
>>
>> The module std.log is finally ready for review. I would like to put it in the review queue for phobos. Here are some links for your documentation:
>>
>> 1. HTML Documentation:
>> http://jsancio.github.com/phobos/phobos/std_log.html
>> 2. Source code: https://github.com/jsancio/phobos/blob/log/std/log.d
>>
>> The module should work as is with the latest druntime. I would really appreciate it if you can try it and comment on the implementation.
>>
>> Thanks,
>> -Jose
>> PS. It has been a while since I tested it in Windows but it should
>> work. I am going to spend some time validating that OS.